lkml.org 
[lkml]   [2012]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Lsf] [RFC] writeback and cgroup
On Mon, Apr 16, 2012 at 09:07:07PM +0800, Fengguang Wu wrote:

[..]
> Vivek, I noticed these lines in cfq code
>
> sscanf(dev_name(bdi->dev), "%u:%u", &major, &minor);
>
> Why not use bdi->dev->devt? The problem is that dev_name() will
> return "btrfs-X" for btrfs rather than "major:minor".

Isn't bdi->dev->devt 0? I see following code.

add_disk()
bdi_register_dev()
bdi_register()
device_create_vargs(MKDEV(0,0))
dev->devt = devt = MKDEV(0,0);

So for normal block devices, I think bdi->dev->devt will be zero, that's
why probably we don't use it.

Thanks
Vivek


\
 
 \ /
  Last update: 2012-04-16 18:13    [from the cache]
©2003-2011 Jasper Spaans