lkml.org 
[lkml]   [2012]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] staging: iio: light: isl29028: fix correct mask value
Date
The mask value in the read_raw/write_raw is absolute
value, not the bit position value.
Fixing this in the implemented function to check value,
not with the bit position value.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
Somehow this was missed on my testing.
I tested today again with linux next and found this issue.

drivers/staging/iio/light/isl29028.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
index e705e45..4e6ac24 100644
--- a/drivers/staging/iio/light/isl29028.c
+++ b/drivers/staging/iio/light/isl29028.c
@@ -272,7 +272,7 @@ static int isl29028_write_raw(struct iio_dev *indio_dev,
mutex_lock(&chip->lock);
switch (chan->type) {
case IIO_PROXIMITY:
- if (mask != IIO_CHAN_INFO_SAMP_FREQ_SEPARATE_BIT) {
+ if (mask != IIO_CHAN_INFO_SAMP_FREQ) {
dev_err(chip->dev,
"proximity: mask value 0x%08lx not supported\n",
mask);
@@ -294,7 +294,7 @@ static int isl29028_write_raw(struct iio_dev *indio_dev,
break;

case IIO_LIGHT:
- if (mask != IIO_CHAN_INFO_SCALE_SEPARATE_BIT) {
+ if (mask != IIO_CHAN_INFO_SCALE) {
dev_err(chip->dev,
"light: mask value 0x%08lx not supported\n",
mask);
@@ -349,14 +349,14 @@ static int isl29028_read_raw(struct iio_dev *indio_dev,
ret = IIO_VAL_INT;
break;

- case IIO_CHAN_INFO_SAMP_FREQ_SEPARATE_BIT:
+ case IIO_CHAN_INFO_SAMP_FREQ:
if (chan->type != IIO_PROXIMITY)
break;
*val = chip->prox_sampling;
ret = IIO_VAL_INT;
break;

- case IIO_CHAN_INFO_SCALE_SEPARATE_BIT:
+ case IIO_CHAN_INFO_SCALE:
if (chan->type != IIO_LIGHT)
break;
*val = chip->lux_scale;
--
1.7.1.1


\
 
 \ /
  Last update: 2012-04-16 18:01    [W:0.034 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site