lkml.org 
[lkml]   [2012]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 04/16] KVM: MMU: return bool in __rmap_write_protect
On Mon, 16 Apr 2012 17:28:32 +0300
Avi Kivity <avi@redhat.com> wrote:

> > But the real question is whether there is any point in re-writing completely
> > correct C code: there are tons of int like this in the kernel code.
> >
> > __rmap_write_protect() was introduced recently, so if this conversion is
> > really worthwhile, I should have been told to use bool at that time, no?
>
> It's up to developer and maintainer preference. I like bool since it
> documents the usage and is safer, but sometimes I miss it on review.

OK.

Thank you for your explanation!

Takuya


\
 
 \ /
  Last update: 2012-04-16 17:57    [W:3.280 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site