Messages in this thread | | | Date | Mon, 16 Apr 2012 08:59:31 -0500 | From | Serge Hallyn <> | Subject | Re: [PATCH] pidns: reboot_pid_ns: use SEND_SIG_FORCED instead of force_sig() |
| |
Quoting Oleg Nesterov (oleg@redhat.com): > Hi Serge, > > On 04/13, Serge Hallyn wrote: > > > > Quoting Oleg Nesterov (oleg@redhat.com): > > > cf3f8921 "pidns: add reboot_pid_ns() to handle the reboot syscall" > > > uses force_sig() to kill the SIGNAL_UNKILLABLE cinit, this was the > > > only choice. > > > > > > After 629d362b we can use SEND_SIG_FORCED instead, force_sig() has > > > the special semantics and should be avoided if possible. > > > > > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > > > > Hi Oleg, > > > > I like the patch in theory, however after applying it containers are > > no longer able to shutdown/reboot. I can externally kill them with > > lxc-stop, but internal shutdown fails. > > Oh, thanks a lot for testing. > > Strange... I even tested this change, but only in the root namespace. > OK, thanks, I'll investigate. I hope you verified your kernel has > 629d362b commit ;)
I took friday's HEAD of Linus tree. All went fine. Added this patch. The container can shutdown, but reboot causes shutdown. Don't undersrtand why.
-serge
| |