Messages in this thread | | | Date | Mon, 16 Apr 2012 15:21:56 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 01/13] edac: Create a dimm struct and move the labels into it |
| |
On Mon, Apr 16, 2012 at 08:44:40AM -0300, Mauro Carvalho Chehab wrote: > Because this will make patch 5/13 even bigger and messy. Each of those > loops have different functions: the first one initializes the legacy API > data structures for virtual csrows/channels, while the second one > initializes the struct that contains the real DIMM or rank information. > > Patches 1 to 4 are just a preparation for patch 5/13, cleaning what's > possible before the big change. > > While it is possible to do the above merge on this patch alone, such > cleanup doesn't make sense at the patch series (and should be reverted > on patch 5/13 anyway), as what we want is to separate the DIMM information > on a data structure that won't mix it with a memory layout-dependent > information, as not all drivers use csrows/channels.
So what?!
Does that mean we do patches in between other patches where code quality is not that good simply because we'll remove that in the later patch? No!
Also, 5/13 is a monster and needs proper splitting anyway. So, if you have a strong technical reason to do two loops, please come forward with it. Otherwise, please change your patches to review requirements as _everyone_ else does on lkml instead of giving some unrelated and bogus reasoning for this and that.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |