Messages in this thread | | | Date | Sun, 15 Apr 2012 09:06:28 -0500 | From | Jonathan Nieder <> | Subject | Re: [regression] Ideapad S10-3 does not wake up from suspend |
| |
Hi,
Quick summary and update.
> Lars Boegild Thomsen writes[1]:
>> After update from 2.6 kernel to 3.0 my Idepad S10-3 will not wake up after >> sleep. [...] >> 983bbf1af0664b78689612b247acb514300f62c7 is the first bad commit
983bbf1af06 is "x86: Don't unmask disabled irqs when migrating them", 2011-05-06, and looks like this:
>> --- a/arch/x86/kernel/irq.c >> +++ b/arch/x86/kernel/irq.c >> @@ -276,7 +276,8 @@ void fixup_irqs(void) >> else if (!(warned++)) >> set_affinity = 0; >> >> - if (!irqd_can_move_in_process_context(data) && chip->irq_unmask) >> + if (!irqd_can_move_in_process_context(data) && >> + !irqd_irq_disabled(data) && chip->irq_unmask) >> chip->irq_unmask(data);
Robert Scott found[1], using 3.2.12:
> I'm getting the same behaviour on my Lenovo Ideapad S10-3
An anonymous contributor[2] also reports the same problem in v3.3.
Lars, Robert, anon: can you try 3.4-rc2 or newer and let us know how it goes? I suspect v3.4-rc2~24^2~4 ("x86: Preserve lazy irq disable semantics in fixup_irqs()") will fix this.
Liu Chuansheng et al: do you think that commit would be a good candidate for inclusion in -stable kernels?
Thanks and hope that helps, Jonathan
> [1] http://bugs.debian.org/635575 [2] https://bugzilla.kernel.org/show_bug.cgi?id=41932
| |