Messages in this thread | | | Date | Sun, 15 Apr 2012 10:54:01 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH 1/2] prctl: Add PR_SET_MM option description |
| |
On Sun, Apr 15, 2012 at 03:48:18PM +1200, Michael Kerrisk (man-pages) wrote: > Cyrill, > > While reviewing your patch to the prctl() manual page, I noticed the > following code inkernel/sys.c::prctl_set_mm(): > > if (opt != PR_SET_MM_START_BRK && opt != PR_SET_MM_BRK) { > /* It must be existing VMA */ > if (!vma || vma->vm_start > addr) > goto out; > } > > At this point, the code causes an exit with error set to zero (i.e., > success). This looks unintended to me. Is the code correct? I suspect > a return of -EFAULT or -ENOMEM is warranted.
Hi Michael, yup, -EINVAL escaped (I think EFAULT or ENOMEM is not really good here). I'll fix and send update. Thanks!
Cyrill
| |