lkml.org 
[lkml]   [2012]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: kvm: RCU warning in async pf
    From
    Date
    On Wed, 2012-04-04 at 15:30 +0300, Gleb Natapov wrote:
    >
    > @@ -253,7 +254,10 @@ do_async_page_fault(struct pt_regs *regs, unsigned long error_code)
    > kvm_async_pf_task_wait((u32)read_cr2());
    > break;
    > case KVM_PV_REASON_PAGE_READY:
    > + rcu_irq_enter();
    > + exit_idle();
    > kvm_async_pf_task_wake((u32)read_cr2());
    > + rcu_irq_exit();
    > break;
    > }
    > }

    Wouldn't irq_enter() / irq_exit() be more appropriate? You're basically
    taking an interrupt/exception from idle, irq_enter() will fix up
    everything that needs fixing up, including time sources (which the
    scheduler expects to be up-to-date).




    \
     
     \ /
      Last update: 2012-04-14 11:49    [W:0.018 / U:59.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site