lkml.org 
[lkml]   [2012]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hfsplus: Fix bless ioctl when used with hardlinks
Il 13/04/2012 16:06, Matthew Garrett ha scritto:
> HFS+ doesn't really implement hard links - instead, hardlinks are indicated
> by a magic file type which refers to an indirect node in a hidden
> directory. The spec indicates that stat() should return the inode number
> of the indirect node, but it turns out that this doesn't satisfy the
> firmware when it's looking for a bootloader - it wants the catalog ID of
> the hardlink file instead. Fix up this case.
>
> Signed-off-by: Matthew Garrett<mjg@redhat.com>
> ---
> fs/hfsplus/ioctl.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/fs/hfsplus/ioctl.c b/fs/hfsplus/ioctl.c
> index c640ba5..5ee0681 100644
> --- a/fs/hfsplus/ioctl.c
> +++ b/fs/hfsplus/ioctl.c
> @@ -31,6 +31,7 @@ static int hfsplus_ioctl_bless(struct file *file, int __user *user_flags)
> struct hfsplus_sb_info *sbi = HFSPLUS_SB(inode->i_sb);
> struct hfsplus_vh *vh = sbi->s_vhdr;
> struct hfsplus_vh *bvh = sbi->s_backup_vhdr;
> + int cnid = (u32)(unsigned long)dentry->d_fsdata;
>

Why a double cast?

Marco


\
 
 \ /
  Last update: 2012-04-14 14:13    [W:0.041 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site