lkml.org 
[lkml]   [2012]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/11] blkcg: make request_queue bypassing on allocation
On Fri, Apr 13, 2012 at 04:55:01PM -0400, Vivek Goyal wrote:
> But neither seems to be the case here. So to make sure that blkg_lookup()
> under rcu will see the updated value of queue flag (bypass), are we
> relying on the fact that caller should see the DEAD flag and not go
> ahead with blkg_lookup()? If yes, atleast it is not obivious.

We're relying on the fact that it doesn't matter anymore because all
blkgs will be shoot down in queue cleanup path which goes through rcu
free, which is different from deactivating individual policies. It
indeed is subtle. Umm... this is starting to get ridiculous. Why the
hell was megaraid messing with so many queues anyways?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-04-13 23:09    [W:0.046 / U:1.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site