Messages in this thread | | | Date | Fri, 13 Apr 2012 14:59:20 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH] HID: hid-lg4ff: Add support for G27 LEDs |
| |
On Mon, 9 Apr 2012, Simon Wood wrote:
> This patch adds supports for controlling the LED 'tachometer' on > the G27 wheel, via the LED subsystem. > > The 5 LEDs are arranged from right (1=grn, 2=grn, 3=yel, 4=yel, 5=red) > and 'mirrored' to the left (10 LEDs in total). > > Signed-off-by: Simon Wood <simon@mungewell.org> > --- > drivers/hid/hid-lg4ff.c | 149 ++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 148 insertions(+), 1 deletions(-)
This patch introduces a clear dependency of hid-lg4ff driver on CONFIG_LEDS_CLASS, but the code doesn't reflect it.
So either you have to put #ifdef into source to compile the leds part out if leds subsystem is not enabled, or you have to introduce Kconfig rule to cover this.
-- Jiri Kosina SUSE Labs
| |