lkml.org 
[lkml]   [2012]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectThinkpad hda regression in 3.3
Hi Takashi and Jaroslav,

We've had a number of bugs reported about sound not working correctly on
various models of Thinkpad machines in the 3.3 kernel. I've listed them
below.

I looked through the commits and found:

commit 29c5fbbcfefba5225a6783683c46c39e10877703:

ALSA: HDA: Use model=auto for Thinkpad T510

The user reports that model=auto works fine for him. Using
model=auto bring in new features such as jack detection notification
to userspace.

I did a local build here with that comment reverted and so far most of
the people reported their sound to be working again. The trivial revert
patch is below in case you want it.

It seems there are multiple models that have PCI ID 17aa:215e and using
model=auto does not work for them all. It particularly messes with
machines using a docking station for some reason.

Aside from just reverting the above commit, do you have other thoughts
on how to fix this?

josh

https://bugzilla.redhat.com/show_bug.cgi?id=808559
https://bugzilla.redhat.com/show_bug.cgi?id=806217
https://bugzilla.redhat.com/show_bug.cgi?id=810697

-----
From: Josh Boyer <jwboyer@redhat.com>
Subject: [PATCH] ALSA: hda - Use model=thinkpad for PCI ID 17aa:215e

Commit 29c5fb "ALSA: HDA: Use model=auto for Thinkpad T510" switched to
using model=auto for PCI ID 17aa:215e, however that breaks sound on a
number of thinkpads. Change this back to using model=thinkpad for now.

Signed-off-by: Josh Boyer <jwboyer@redhat.com>

---
--- linux-3.3.noarch.orig/sound/pci/hda/patch_conexant.c
+++ linux-3.3.noarch/sound/pci/hda/patch_conexant.c
@@ -3027,7 +3027,7 @@ static const struct snd_pci_quirk cxt506
SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400s", CXT5066_THINKPAD),
SND_PCI_QUIRK(0x17aa, 0x21c5, "Thinkpad Edge 13", CXT5066_THINKPAD),
SND_PCI_QUIRK(0x17aa, 0x21c6, "Thinkpad Edge 13", CXT5066_ASUS),
- SND_PCI_QUIRK(0x17aa, 0x215e, "Lenovo T510", CXT5066_AUTO),
+ SND_PCI_QUIRK(0x17aa, 0x215e, "Lenovo T510", CXT5066_THINKPAD),
SND_PCI_QUIRK(0x17aa, 0x21cf, "Lenovo T520 & W520", CXT5066_AUTO),
SND_PCI_QUIRK(0x17aa, 0x21da, "Lenovo X220", CXT5066_THINKPAD),
SND_PCI_QUIRK(0x17aa, 0x21db, "Lenovo X220-tablet", CXT5066_THINKPAD),

\
 
 \ /
  Last update: 2012-04-13 14:45    [from the cache]
©2003-2011 Jasper Spaans