[lkml]   [2012]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH RFC] vfs: make fstatat retry on ESTALE errors from getattr call
    Jeff Layton wrote:

    error = user_path_at(dfd, filename, lookup_flags, &path);
    if (error)
    goto out;

    error = vfs_getattr(path.mnt, path.dentry, stat);
    + should_retry = error == -ESTALE ? retry_estale(path.dentry) : false;
    + if (should_retry) {
    + lookup_flags |= LOOKUP_REVAL;
    + goto retry;
    + }
    return error;

    This is starting to look like FORTRAN. Maybe turn this into a "do while"?
    Then you could make the "goto out" into a break and get rid of them both.

     \ /
      Last update: 2012-04-13 14:13    [W:0.020 / U:3.308 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site