Messages in this thread | | | Date | Thu, 12 Apr 2012 23:50:02 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] stack usage: Add pid to warning printk in check_stack_usage |
| |
On 04/11, Tim Bird wrote: > > In embedded systems, sometimes the same program (busybox) > is the cause of multiple warnings. Outputting the pid > with the program name in the warning printk helps > distinguish which instances of a program are using > the stack most. > > This is a small patch, but useful.
Agreed, pid_nr alone is useless if you read the logs when this app has already terminated.
> Signed-off-by: Tim Bird <tim.bird@am.sony.com> > --- > exit.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/exit.c b/kernel/exit.c > index b8a6a09..bad923d 100644 > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -898,9 +898,9 @@ static void check_stack_usage(void) > > spin_lock(&low_water_lock); > if (free < lowest_to_date) { > - printk(KERN_WARNING "%s used greatest stack depth: %lu bytes " > - "left\n", > - current->comm, free); > + printk(KERN_WARNING "%s (%d) used greatest stack depth: " > + "%lu bytes left\n", > + current->comm, task_pid_nr(current), free); > lowest_to_date = free; > } > spin_unlock(&low_water_lock); >
| |