Messages in this thread | | | Date | Thu, 12 Apr 2012 15:47:40 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf tools: fix NO_GTK2 Makefile config error |
| |
Em Thu, Apr 12, 2012 at 10:55:48AM +0200, Stephane Eranian escreveu: > On Thu, Apr 12, 2012 at 7:19 AM, Namhyung Kim <namhyung.kim@lge.com> wrote: > > Hi, Stephane > > > > On Tue, 10 Apr 2012 12:35:13 +0200, Stephane Eranian wrote: > >> In case the user specified NO_GTK2 on the make cmdline, > >> compilation would fail with undefined symbol because the > >> Makefile would not set the correct cpp variable: > >> NO_GTK2 vs. NO_GTK2_SUPPORT. > >> > >> This patch renames the variable to the correct name. > >> > > > > I already sent a patch for this. Please see below: > > > > https://lkml.org/lkml/2012/4/11/459 > > > Ok, I was not copied onto your post. And then the fix is buried with others > unrelated changes, it seems. But fine with me. It just needs to be committed > now.
Yeah, would be better to have it as a separate patch, just the fix :-\
I think I'll pick Stephane's fix, stash it in perf/urgent, as your cset that included the build fix is only in perf/core.
Repo at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux
- Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |