Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 11 Apr 2012 21:39:29 -0700 | Subject | Re: hlist_for_each_entry && pos (Was: task_work_queue) |
| |
On Wed, Apr 11, 2012 at 9:28 PM, Oleg Nesterov <oleg@redhat.com> wrote: > > Agreed. But, > > error: 'for' loop initial declaration used outside C99 mode > > we should change CFLAGS, I guess. BTW, personally I'd like very much > to use "for (type var; ...")" if this was allowed.
The sad part is that if we allow that, we also get that *other* insane C99 variable thing - mixing variables and code.
I *like* getting warnings for confused people who start introducing variables in the middle of blocks of code. That's not well-contained like the loop variable.
That said, most of the stuff in C99 are extensions that we used long before C99, so I guess we might as well just add the stupid flag. And discourage people from mixing declarations and code other ways (sparse etc).
Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |