lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC V5 3/6] kvm : Add unhalt msr to aid (live) migration
    On Fri, Mar 23, 2012 at 01:37:26PM +0530, Raghavendra K T wrote:
    > From: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
    >
    > Currently guest does not need to know pv_unhalt state and intended to be
    > used via GET/SET_MSR ioctls during migration.
    >
    > Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
    > ---
    > diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h
    > index 9234f13..46f9751 100644
    > --- a/arch/x86/include/asm/kvm_para.h
    > +++ b/arch/x86/include/asm/kvm_para.h
    > @@ -40,6 +40,7 @@
    > #define MSR_KVM_SYSTEM_TIME_NEW 0x4b564d01
    > #define MSR_KVM_ASYNC_PF_EN 0x4b564d02
    > #define MSR_KVM_STEAL_TIME 0x4b564d03
    > +#define MSR_KVM_PV_UNHALT 0x4b564d04
    >
    > struct kvm_steal_time {
    > __u64 steal;
    > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
    > index bd5ef91..38e6c47 100644
    > --- a/arch/x86/kvm/x86.c
    > +++ b/arch/x86/kvm/x86.c
    > @@ -784,12 +784,13 @@ EXPORT_SYMBOL_GPL(kvm_rdpmc);
    > * kvm-specific. Those are put in the beginning of the list.
    > */
    >
    > -#define KVM_SAVE_MSRS_BEGIN 9
    > +#define KVM_SAVE_MSRS_BEGIN 10
    > static u32 msrs_to_save[] = {
    > MSR_KVM_SYSTEM_TIME, MSR_KVM_WALL_CLOCK,
    > MSR_KVM_SYSTEM_TIME_NEW, MSR_KVM_WALL_CLOCK_NEW,
    > HV_X64_MSR_GUEST_OS_ID, HV_X64_MSR_HYPERCALL,
    > HV_X64_MSR_APIC_ASSIST_PAGE, MSR_KVM_ASYNC_PF_EN, MSR_KVM_STEAL_TIME,
    > + MSR_KVM_PV_UNHALT,
    > MSR_IA32_SYSENTER_CS, MSR_IA32_SYSENTER_ESP, MSR_IA32_SYSENTER_EIP,
    > MSR_STAR,
    > #ifdef CONFIG_X86_64
    > @@ -1606,7 +1607,9 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, u32 msr, u64 data)
    > kvm_make_request(KVM_REQ_STEAL_UPDATE, vcpu);
    >
    > break;
    > -
    > + case MSR_KVM_PV_UNHALT:
    > + vcpu->pv_unhalted = (u32) data;
    > + break;
    > case MSR_IA32_MCG_CTL:
    > case MSR_IA32_MCG_STATUS:
    > case MSR_IA32_MC0_CTL ... MSR_IA32_MC0_CTL + 4 * KVM_MAX_MCE_BANKS - 1:
    > @@ -1917,6 +1920,9 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, u32 msr, u64 *pdata)
    > case MSR_KVM_STEAL_TIME:
    > data = vcpu->arch.st.msr_val;
    > break;
    > + case MSR_KVM_PV_UNHALT:
    > + data = (u64)vcpu->pv_unhalted;
    > + break;
    > case MSR_IA32_P5_MC_ADDR:
    > case MSR_IA32_P5_MC_TYPE:
    > case MSR_IA32_MCG_CAP:

    Unless there is a reason to use an MSR, should use a normal ioctl
    such as KVM_{GET,SET}_MP_STATE.



    \
     
     \ /
      Last update: 2012-04-12 02:21    [W:0.023 / U:0.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site