lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 32/42] x86/PCI: do not tie MSI MS-7253 use_crs quirk to BIOS version
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jonathan Nieder <jrnieder@gmail.com>

    commit a97f4f5e524bcd09a85ef0b8821a14d35e69335f upstream.

    Carlos was getting

    WARNING: at drivers/pci/pci.c:118 pci_ioremap_bar+0x24/0x52()

    when probing his sound card, and sound did not work. After adding
    pci=use_crs to the kernel command line, no more trouble.

    Ok, we can add a quirk. dmidecode output reveals that this is an MSI
    MS-7253, for which we already have a quirk, but the short-sighted
    author tied the quirk to a single BIOS version, making it not kick in
    on Carlos's machine with BIOS V1.2. If a later BIOS update makes it
    no longer necessary to look at the _CRS info it will still be
    harmless, so let's stop trying to guess which versions have and don't
    have accurate _CRS tables.

    Addresses https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5533
    Also see <https://bugzilla.kernel.org/show_bug.cgi?id=42619>.

    Reported-by: Carlos Luna <caralu74@gmail.com>
    Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
    Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/x86/pci/acpi.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/arch/x86/pci/acpi.c
    +++ b/arch/x86/pci/acpi.c
    @@ -62,7 +62,6 @@ static const struct dmi_system_id pci_us
    DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
    DMI_MATCH(DMI_BOARD_NAME, "MS-7253"),
    DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies, LTD"),
    - DMI_MATCH(DMI_BIOS_VERSION, "V1.6"),
    },
    },
    {}



    \
     
     \ /
      Last update: 2012-04-12 01:35    [W:0.020 / U:33.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site