lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] remove BUG() in possible but rare condition
On Wed, 11 Apr 2012, Linus Torvalds wrote:

> > I am not familiar with the code much but a trivial call chain walk up to
> > write_dev_supers (in btrfs) shows that we do not check for the return value
> > from __getblk so we would nullptr and there might be more.
> > I guess these need some treat before the BUG might be removed, right?
>
> Well, realistically, isn't BUG() as bad as a NULL pointer dereference?

Well, there still could be weirdos out there not setting
sys.vm.mmap_min_addr to something sane. For those, NULL pointer
dereference could have worse consequences than BUG (unlikely in this
particular case, yes).

--
Jiri Kosina
SUSE Labs



\
 
 \ /
  Last update: 2012-04-11 23:35    [from the cache]
©2003-2011 Jasper Spaans