lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] dma/amba-pl08x: add support for the Nomadik variant
On 4/11/2012 1:29 PM, Linus Walleij wrote:
>>> >> + ch->locked = true;
>>> >> + } else
>>> >> + ch->locked = false;
>>> >> + }
>>> >> +
>> >
>> > Memory for ch is allocated with kmalloc and so its default value is garbage.
>> > So we must set locked to false in else part here.
> Hm maybe better to kzalloc() the channel structs?
>

Then, you can remove code which makes its field zero explicitly, as it is already
zero.

--
viresh


\
 
 \ /
  Last update: 2012-04-11 10:03    [W:0.048 / U:2.820 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site