lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] block: mtip32xx: remove HOTPLUG_PCI_PCIE dependancy
    On Wed, Apr 11, 2012 at 01:33:39PM -0700, Asai Thambi S P wrote:
    > On 4/11/2012 12:57 PM, Jens Axboe wrote:
    >
    > > On 2012-04-11 20:34, Greg KH wrote:
    > >> This removes the HOTPLUG_PCI_PCIE dependency on the driver and makes it
    > >> depend on PCI.
    > >
    > > I think it's an old dependency. I've built and run it here without as
    > > well, and no functional issues either.
    > >
    > > Sam/Asai?
    > >
    >
    >
    > Both driver and device will work fine without PCIe hotplug dependency. This
    > dependency is required for supporting surprise removal and surprise insertion
    > of the device on systems with PCIe hotplug controller.

    But that's not a driver-specific thing at all. All PCI drivers need to
    be able to handle this (I like how you constantly check the pci id,
    that's cute.)

    So I think a basic dependancy on PCI should be fine here.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2012-04-11 22:43    [W:0.023 / U:30.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site