lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 06/16] sched: SCHED_DEADLINE push and pull logic
    From
    Date
    On Fri, 2012-04-06 at 09:14 +0200, Juri Lelli wrote:
    >
    > @@ -543,6 +897,9 @@ static void put_prev_task_dl(struct rq *rq, struct task_struct *p)
    > {
    > update_curr_dl(rq);
    > p->se.exec_start = 0;
    > +
    > + if (on_dl_rq(&p->dl) && p->dl.nr_cpus_allowed > 1)
    > + enqueue_pushable_dl_task(rq, p);
    > }

    Ouch! We need to fix this. This has nothing to do with your patch
    series, but if you look at schedule():

    put_prev_task(rq, prev);
    next = pick_next_task(rq);


    We put the prev task and then pick the next task. If we call schedule
    for some reason when we don't need to really schedule, then we just
    added and removed from the pushable rb tree the same task. That is, we
    did the rb manipulation twice, for no good reason.

    Not sure how to fix this. But it will require a generic change.

    -- Steve




    \
     
     \ /
      Last update: 2012-04-11 18:35    [W:0.021 / U:31.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site