lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: i915_driver_irq_handler: irq 42: nobody cared
From
Date
On Die, 2012-04-10 at 11:34 -0700, Jesse Barnes wrote: 
> On Tue, 10 Apr 2012 20:11:29 +0200
> Jiri Slaby <jslaby@suse.cz> wrote:
>
> > On 04/10/2012 06:26 PM, Jesse Barnes wrote:
> > > So port hotplug is always reporting that port C has a hotplug
> > > interrupt though... If you write 0x3 back to it does the interrupt
> > > stop?
> >
> > I'm not sure I got it right. This doesn't help:
> > --- a/drivers/gpu/drm/i915/i915_irq.c
> > +++ b/drivers/gpu/drm/i915/i915_irq.c
> > @@ -1416,6 +1416,17 @@ static irqreturn_t
> > i915_driver_irq_handler(DRM_IRQ_ARGS)
> > iir = new_iir;
> > }
> >
> > + if (ret == IRQ_NONE) {
> > + u32 hp = I915_READ(PORT_HOTPLUG_STAT);
> > + if (hp) {
> > + I915_WRITE(PORT_HOTPLUG_STAT, hp);
> > + I915_READ(PORT_HOTPLUG_STAT);
> > + }
> > +
> > + if (printk_ratelimit())
> > + printk(KERN_DEBUG "%s: %.8x\n", __func__, hp);
> > +
> > + }
> >
> > return ret;
> > }
>
> Yeah that looks right, you still get 0x300?

You said 'If you write 0x3 back' above, but this code writes 0x300.
Which is right?


--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-04-11 08:33    [W:0.107 / U:0.024 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site