Messages in this thread | | | Date | Wed, 11 Apr 2012 18:09:09 +0200 | From | Juri Lelli <> | Subject | Re: [PATCH 06/16] sched: SCHED_DEADLINE push and pull logic |
| |
On 04/11/2012 06:00 PM, Steven Rostedt wrote: > On Sun, 2012-04-08 at 22:20 +0200, Juri Lelli wrote: >>> >>>>>> +#ifdef CONFIG_SMP >>>>>> + /* >>>>>> + * In the unlikely case current and p have the same deadline >>>>>> + * let us try to decide what's the best thing to do... >>>>>> + */ >>>>>> + if ((s64)(p->dl.deadline - rq->curr->dl.deadline) == 0&& >>>>>> + !need_resched()) >>>>> >>>>> please recheck !need_resched(), say rq->curr need reschedule? >>>> >>>> Sorry, I don't get this.. >>>> >>> Perhaps smp_processor_id() != rq->cpu >>> >> >> need_resched is actually checked... >> > > I guess what Hillf is trying to say is, > > s/!need_resched()/!test_tsk_need_resched(rq->curr)/ >
Yep, I finally got (and changed) it ;-).
Thanks,
- Juri
| |