lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/16] sched: SCHED_DEADLINE push and pull logic
    On 04/11/2012 06:00 PM, Steven Rostedt wrote:
    > On Sun, 2012-04-08 at 22:20 +0200, Juri Lelli wrote:
    >>>
    >>>>>> +#ifdef CONFIG_SMP
    >>>>>> + /*
    >>>>>> + * In the unlikely case current and p have the same deadline
    >>>>>> + * let us try to decide what's the best thing to do...
    >>>>>> + */
    >>>>>> + if ((s64)(p->dl.deadline - rq->curr->dl.deadline) == 0&&
    >>>>>> + !need_resched())
    >>>>>
    >>>>> please recheck !need_resched(), say rq->curr need reschedule?
    >>>>
    >>>> Sorry, I don't get this..
    >>>>
    >>> Perhaps smp_processor_id() != rq->cpu
    >>>
    >>
    >> need_resched is actually checked...
    >>
    >
    > I guess what Hillf is trying to say is,
    >
    > s/!need_resched()/!test_tsk_need_resched(rq->curr)/
    >

    Yep, I finally got (and changed) it ;-).

    Thanks,

    - Juri


    \
     
     \ /
      Last update: 2012-04-11 18:11    [W:0.025 / U:58.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site