lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: i915_driver_irq_handler: irq 42: nobody cared
    On Wed, 11 Apr 2012 08:29:22 +0200
    Michel Dänzer <michel@daenzer.net> wrote:

    > On Die, 2012-04-10 at 11:34 -0700, Jesse Barnes wrote:
    > > On Tue, 10 Apr 2012 20:11:29 +0200
    > > Jiri Slaby <jslaby@suse.cz> wrote:
    > >
    > > > On 04/10/2012 06:26 PM, Jesse Barnes wrote:
    > > > > So port hotplug is always reporting that port C has a hotplug
    > > > > interrupt though... If you write 0x3 back to it does the interrupt
    > > > > stop?
    > > >
    > > > I'm not sure I got it right. This doesn't help:
    > > > --- a/drivers/gpu/drm/i915/i915_irq.c
    > > > +++ b/drivers/gpu/drm/i915/i915_irq.c
    > > > @@ -1416,6 +1416,17 @@ static irqreturn_t
    > > > i915_driver_irq_handler(DRM_IRQ_ARGS)
    > > > iir = new_iir;
    > > > }
    > > >
    > > > + if (ret == IRQ_NONE) {
    > > > + u32 hp = I915_READ(PORT_HOTPLUG_STAT);
    > > > + if (hp) {
    > > > + I915_WRITE(PORT_HOTPLUG_STAT, hp);
    > > > + I915_READ(PORT_HOTPLUG_STAT);
    > > > + }
    > > > +
    > > > + if (printk_ratelimit())
    > > > + printk(KERN_DEBUG "%s: %.8x\n", __func__, hp);
    > > > +
    > > > + }
    > > >
    > > > return ret;
    > > > }
    > >
    > > Yeah that looks right, you still get 0x300?
    >
    > You said 'If you write 0x3 back' above, but this code writes 0x300.
    > Which is right?

    0x300 is right, the bits are status bits with write 1 to clear
    semantics. But it looks like this one is just stuck high (probably
    because port C isn't actually wired up fully).

    --
    Jesse Barnes, Intel Open Source Technology Center
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-04-11 18:05    [W:0.025 / U:32.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site