lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRe: [PATCH] iqrdomain: Improve formatting in debugfs.
    On Wed, Apr 11, 2012 at 8:52 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
    > On Wed, Apr 11, 2012 at 3:16 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
    >> Grant Likely <grant.likely@secretlab.ca> writes:
    >>
    >>> @@ -667,7 +667,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
    >>>                       seq_printf(m, "%-15s  ", p);
    >>>
    >>>                       data = irq_desc_get_chip_data(desc);
    >>> -                     seq_printf(m, "0x%16p  ", data);
    >>> +                     seq_printf(m, data ? "0x%p  " : "  %p  ", data);
    >>
    >> You should be able to use %#p instead to let it add the prefix.
    >
    > That mostly works, but it doesn't round up the field size to account
    > for the 2 characters in '0x'.  Looks like the %p code needs to be
    > tweaked to fix that.

    which this change does:

    diff --git a/lib/vsprintf.c b/lib/vsprintf.c
    index abbabec..4c4f2ce 100644
    --- a/lib/vsprintf.c
    +++ b/lib/vsprintf.c
    @@ -946,6 +946,8 @@ char *pointer(const char *fmt, char *buf, char
    *end, void *ptr,
    if (spec.field_width == -1) {
    spec.field_width = 2 * sizeof(void *);
    spec.flags |= ZEROPAD;
    + if (spec.flags & SPECIAL)
    + spec.field_width += 2;
    }
    spec.base = 16;
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2012-04-11 17:01    [W:0.023 / U:125.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site