lkml.org 
[lkml]   [2012]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] net: orphan queued skbs if device tx can stall
    From
    Date
    On Tue, 2012-04-10 at 12:31 +0300, Michael S. Tsirkin wrote:

    > True. Still this is the only interface we have for controlling
    > the internal queue length so it seems safe to assume someone
    > is using it for this purpose.
    >

    So to workaround a problem in tun, you want to hack net/core/dev.c :(

    Packets in qdisc should not be orphaned.

    If you think about it, why do we attach skb to socket in the first
    place ?

    If its not needed for tun, why should it be needed for other devices ?

    If TUN has a problem being stopped forever, maybe it should take
    appropriate action to flush all packets in qdisc queue after a while, as
    this makes no sense to delay packets forever.





    \
     
     \ /
      Last update: 2012-04-10 12:07    [W:0.019 / U:62.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site