[lkml]   [2012]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/2] clkdev: Implement managed clk_get()
On Sun, Apr 01, 2012 at 08:26:10AM -0700, Stephen Boyd wrote:
> On 4/1/2012 4:32 AM, Mark Brown wrote:

> > Documentation/driver-model/devres.txt | 3 +++
> > drivers/clk/clkdev.c | 25 +++++++++++++++++++++++++
> > include/linux/clk.h | 20 ++++++++++++++++++++
> > 3 files changed, 48 insertions(+), 0 deletions(-)

> But why is this part of clkdev.c? devm_clk_get() should work regardless
> of the implementation of clk_get() so can we put it into some other file
> that is compiled if HAVE_CLK=y so everyone benefits from this and not
> just users who select CLKDEV_LOOKUP?

Mostly just because clk_get() is part of clkdev.c and I didn't feel like
creating a new file, though also because I really hope that we're going
to be moving away from open coding clock framework things so that we can
start to push clock API usage into non-SoC code. Things like adding new
clocks are going to be a part of that.

To put it another way, why would a platform want to avoid clkdev?
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2012-04-01 17:37    [W:0.087 / U:19.260 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site