Messages in this thread Patch in this message | | | From | Jan Kara <> | Subject | [PATCH 1/4] fs: Remove bogus wait in write_inode_now() | Date | Fri, 9 Mar 2012 10:02:25 +0100 |
| |
inode_sync_wait() in write_inode_now() is just bogus. That function waits for I_SYNC bit to be cleared but writeback_single_inode() clears the bit on return so the wait is effectivelly a nop unless someone else submits the inode for writeback again. All the waiting write_inode_now() needs is achieved by using WB_SYNC_ALL writeback mode.
Signed-off-by: Jan Kara <jack@suse.cz> --- fs/fs-writeback.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 5b4a936..f60297b 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -1364,8 +1364,6 @@ int write_inode_now(struct inode *inode, int sync) ret = writeback_single_inode(inode, wb, &wbc); spin_unlock(&inode->i_lock); spin_unlock(&wb->list_lock); - if (sync) - inode_sync_wait(inode); return ret; } EXPORT_SYMBOL(write_inode_now); -- 1.7.1
| |