Messages in this thread | | | Date | Fri, 9 Mar 2012 23:13:02 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: use enum instead of literals for trap values |
| |
* H. Peter Anvin <hpa@zytor.com> wrote:
> On 03/09/2012 10:52 AM, Steven Rostedt wrote: > > I agree too, except where does "XCP" come from? Is it short for > > "exception"? > > Yes, short for "exception". I hate to admit it, but it comes from the > constants we used in the Transmeta microcode ;)
Hm, were I to see 'X86_XCP_MC' for the first time I'd have no idea what it means. Really, lets not use random new abbreviations, lets use well-known patterns.
Make it X86_TRAP_XX, it's both short and correct?
Thanks,
Ingo
| |