lkml.org 
[lkml]   [2012]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] x86: use enum instead of literals for trap values
From
On Fri, Mar 9, 2012 at 9:57 AM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 03/09/2012 08:30 AM, Kees Cook wrote:
>> On Fri, Mar 9, 2012 at 1:28 AM, Ingo Molnar <mingo@elte.hu> wrote:
>>>
>>> * Kees Cook <keescook@chromium.org> wrote:
>>>
>>>> The traps are referred to by their numbers and it can be difficult to
>>>> understand them while reading the code without context. This patch adds
>>>> enumeration of the trap numbers and replaces the numbers with the correct
>>>> enum for x86.
>>>>
>
> I have to admit personally to prefer something like X86_XCP_XX where XX
> is the two-letter code that the Intel documentation uses for that trap,
> i.e. #GP, #BR, #MC and so on.

We need a single person to decide on this bike shed color. :) If the
list of enum names can be agreed on, I'll be happy to do the
search/replace for it.

-Kees

--
Kees Cook
ChromeOS Security


\
 
 \ /
  Last update: 2012-03-09 19:25    [from the cache]
©2003-2011 Jasper Spaans