lkml.org 
[lkml]   [2012]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 1/5] Extcon (external connector): import Android's switch class and modify.
On Mon, Feb 27, 2012 at 09:15:35PM +0900, MyungJoo Ham wrote:

> +#ifdef CONFIG_ANDROID
> + extcon_class = class_create(THIS_MODULE, "switch");
> +#else /* !CONFIG_ANDROID */
> + extcon_class = class_create(THIS_MODULE, "extcon");
> +#endif /* CONFIG_ANDROID */

This seems somewhat sad - if ANDROID is turned on the standard ABI
vanishes. It'd be much nicer to do this with a symlink (or with
symlinks within the android directory if the driver core doesn't support
that). That way userspace code can be written to the new ABI and will
work on Android systems without ifdefery.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-03-09 13:43    [W:0.080 / U:2.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site