Messages in this thread | | | Date | Fri, 9 Mar 2012 12:57:21 +0100 | Subject | Re: [PATCH v2 01/13] dmaengine: imx-dma: merge old dma-v1.c with imx-dma.c | From | javier Martin <> |
| |
On 9 March 2012 12:00, Sascha Hauer <s.hauer@pengutronix.de> wrote: > On Wed, Mar 07, 2012 at 03:33:33PM +0100, Javier Martin wrote: >> It is mainly a simple merge changing the prefix of some >> functions to fit the imx-dma namings. >> >> As there are no users of the old dma-v1.c api we can safely >> remove this file. >> >> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com> >> --- >> @@ -633,11 +1127,8 @@ static int __exit imxdma_remove(struct platform_device *pdev) >> >> dma_async_device_unregister(&imxdma->dma_device); >> >> - for (i = 0; i < MAX_DMA_CHANNELS; i++) { >> - struct imxdma_channel *imxdmac = &imxdma->channel[i]; >> - >> - imx_dma_free(imxdmac->imxdma_channel); >> - } >> + for (i = 0; i < MAX_DMA_CHANNELS; i++) >> + free_irq(MX2x_INT_DMACH0 + i, NULL); > > This lacks a test for i.MX1/21/27. The above is correct for i.MX21/27, > but on i.MX1 you have to free MX1_DMA_INT/MX1_DMA_ERR.
This series has only been tested for i.MX27. So, to those reviewing the code, please pay special attention to i.MX1 part.
Sascha, thank you for your comment, I will fix it for the next version.
Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |