lkml.org 
[lkml]   [2012]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] powerpc/44x: Fix PCI MSI support for Maui APM821xx SoC and Bluestone board
From
Date
On Fri, 2012-03-09 at 10:17 +0700, Mai La wrote:
> This patch consists of:
> - Enable PCI MSI as default for Bluestone board
> - Define number of MSI interrupt for Maui APM821xx SoC using in Bluestone board
> - Fix returning ENODEV as finding MSI node
> - Fix MSI physical high and low address
> - Keep MSI data logically
>
> Signed-off-by: Mai La <mla@apm.com>
> ---

> index 7b4df37..c86231e 100644
> --- a/arch/powerpc/sysdev/Kconfig
> +++ b/arch/powerpc/sysdev/Kconfig
> @@ -20,6 +20,12 @@ config PPC_MSI_BITMAP
> default y if FSL_PCI
> default y if PPC4xx_MSI
>
> +config PPC4xx_NR_MSI_IRQS
> + int "Number of PCI MSI interrupts"
> + depends on PCI_MSI && PPC4xx_MSI
> + default "4" if !APM821xx
> + default "8" if APM821xx
> +

.../...

> +#define NR_MSI_IRQS CONFIG_PPC4xx_NR_MSI_IRQS

ARGH.

We asked to -NOT MAKE THIS A COMPILE TIME OPTION-

CONFIG_foo is as bad as your previous ifdef, in fact you just added a
useless config option here.

Make that number dynamic. Count the entries in the device-tree (or add
a property with the number in it, whatever you fancy the most) but make
it something detected at RUNTIME !!!!!

Ben.




\
 
 \ /
  Last update: 2012-03-09 04:39    [W:0.036 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site