lkml.org 
[lkml]   [2012]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix memory leak in sysfs_sd_setsecdata().
On Thu, Mar 08, 2012 at 01:02:20PM -0800, Eric W. Biederman wrote:
> Masami Ichikawa <masami256@gmail.com> writes:
>
> > This patch fixies follwing two memory leak patterns that reported by kmemleak.
> > sysfs_sd_setsecdata() is called during sys_lsetxattr() operation.
> > It checks sd->s_iattr is NULL or not. Then if it is NULL, it calls
> > sysfs_init_inode_attrs() to allocate memory.
> > That code is this.
>
> I don't know how you count two memory leaks. But there is definitely a
> leak here sd->s_iattr is allocated and then never assigned. It looks
> like I introduced that leak when I re-factored the code to protect
> the code with sysfs_mutex at the end of 2009.
>
> I am surprise the securlity label crowd has not been screaming about
> selinux protection not working on sysfs for the last two years.
>
> I have reviewed the code and the fix looks obvious and correct.
>
> Greg can you pick this up?

I applied it a while ago to my tree already :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-03-08 22:17    [W:0.084 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site