lkml.org 
[lkml]   [2012]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] perf report: Implement symbol filtering on TUI

* Namhyung Kim <namhyung.kim@lge.com> wrote:

> Hi, Ingo
>
> 2012-03-07 3:07 PM, Ingo Molnar wrote:
> >
> >* Namhyung Kim <namhyung.kim@lge.com> wrote:
> >
> >>As Ingo requested, symbol filtering feature was missing on TUI.
> >>Add 's' key to get input from user, and do simple filtering by
> >>strstr(). To turn filtering off, just enter no name by pressing
> >>'s' followed by ENTER.
> >>
> >>There should be many issues, but I just want to release this
> >>to get some feedbacks.
> >
> >I'd love it if in addition to the hotkey, if I typed the obvious
> >sequence:
> >
> > $ perf report sched
> >
> >... then it would turn into such a filter automagically.
> >
>
> Oh, I implemented that already. Please test it! :)

Cool - I tried it out and it works just as it should!

I noticed two details:

- "perf report sched | less" does not work as expected - such
kinds of features should be GUI-frontend agnostic.

- unknown symbols are not matched, and thus they will show up
indiscrimnately even though I only want to see them if the
filter is something like '0x' or 'unknown'.

Anyway, apart from these two details:

Tested-by: Ingo Molnar <mingo@elte.hu>

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-03-08 11:47    [W:0.096 / U:4.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site