Messages in this thread | | | Date | Wed, 7 Mar 2012 16:06:33 -0800 | From | Tejun Heo <> | Subject | Re: [PATCHSET] blkcg: accumulated blkcg updates |
| |
Hello,
On Tue, Mar 06, 2012 at 02:02:11PM -0500, Vivek Goyal wrote: > Ok, found it. Basically we have not initialized the q->queue_head during > queue creation. Hence we end up thinking that q->queue_head is not empty. > > So following fixed the issue for me. I still don't understand the special > cased code (q->queue_head is not empty but don't kick queue).
It was mainly to avoid adding a new requirement as we didn't use to require queue_head to be empty on exit. I didn't realize we weren't initializing queue_head from alloc. Jens folded your fix into the original patch, so we might not need the special case anymore.
I'll post fix for the RCU deref warning shortly.
Thanks.
-- tejun
| |