Messages in this thread | | | Date | Wed, 7 Mar 2012 21:37:01 +0530 | Subject | Re: [PATCH] [SCSI] sd: set BIO_MAPPED_INTEGRITY bit correctly in sd_dif_prepare(). | From | santosh prasad nayak <> |
| |
On Wed, Mar 7, 2012 at 9:26 PM, Matthew Wilcox <matthew@wil.cx> wrote: > On Wed, Mar 07, 2012 at 08:11:35PM +0530, santosh nayak wrote: >> From: Santosh Nayak <santoshprasadnayak@gmail.com> >> >> Value of BIO_MAPPED_INTEGRITY is 11. Intention was to set the 11th bit. > > Also, can we introduce: > > #define bio_set_flag(bio, flag) ((bio)->bi_flags |= (1 << (flag))) >
set_bit() can do the same task. Can you please explain why do we need a new macro ?
> Then hunt down and kill all the places that manipulate bi_flags by hand? > We might also need: > > #define bio_set_flag_atomic(bio, flag) set_bit(&(bio)->bi_flags, (flag))
for atomic operation we have __set_bit() . Is there any need to define to new macro ?
Regards Santosh
> > -- > Matthew Wilcox Intel Open Source Technology Centre > "Bill, look, we understand that you're interested in selling us this > operating system, but compare it to ours. We can't possibly take such > a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |