Messages in this thread | | | Date | Wed, 7 Mar 2012 11:18:37 -0300 | From | Rafael Aquini <> | Subject | Re: [PATCH -v2] mm: SLAB Out-of-memory diagnostics |
| |
Howdy David,
On Tue, Mar 06, 2012 at 07:41:55PM -0800, David Rientjes wrote: > > + spin_lock_irqsave(&l3->list_lock, flags); > > Could be spin_lock_irq(&l3->list_lock);
I don't think it would be safe making such assumption.
Note that spin_lock_irqsave() is used at slab_out_of_memory() because we cannot guarantee that interrupts will be enabled/disabled by the time kmem_getpages() is called in cache_grow() or fallback_alloc().
Rafael
| |