lkml.org 
[lkml]   [2012]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v2] mm: SLAB Out-of-memory diagnostics
Howdy David,

On Tue, Mar 06, 2012 at 07:41:55PM -0800, David Rientjes wrote:
> > + spin_lock_irqsave(&l3->list_lock, flags);
>
> Could be spin_lock_irq(&l3->list_lock);

I don't think it would be safe making such assumption.

Note that spin_lock_irqsave() is used at slab_out_of_memory() because we cannot
guarantee that interrupts will be enabled/disabled by the time kmem_getpages()
is called in cache_grow() or fallback_alloc().

Rafael


\
 
 \ /
  Last update: 2012-03-07 15:23    [W:0.066 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site