lkml.org 
[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124
    From
    On Tue, Mar 6, 2012 at 9:12 PM, Mark Brown
    <broonie@opensource.wolfsonmicro.com> wrote:
    >> > This is not what the above prototype says, the above prototype has only
    >> > one register in it.  You need to make this *much* clearer for the
    >> > registers it's affecting.
    >> Sorry, I couldn't understand your saying / concern.
    >> Do you mean I shouldn't use ml26124_update_bits() but snd_soc_update_bits() ?
    > Ideally you should be using the framework features.  If there is some
    > reason why you can't you need to make it much clearer what the reason
    > is so people reading the code can understand.

    If possible, I want to use framework features. However, I judged it is
    not possible.
    Let me confirm again.
    As I said before, all ML26124 registers need to be accessed by
    different address when read and write.
    Like below
    R W
    $00h $01h Sampling setting
    $02h $03h PLL setting
    ...

    Even so, can I use framework features ?

    thanks,
    --
    ROHM Co., Ltd.
    tomoya
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-07 03:19    [W:0.022 / U:0.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site