lkml.org 
[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH RT 04/25][RFC 3.0.23-rt39-rc1] revert-seqlock-remove-unused-functions
    From
    On Tue, Mar 6, 2012 at 5:16 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
    > From: Steven Rostedt <rostedt@goodmis.org>
    >
    > revert: seqlock-remove-unused-functions.patch
    >
    > Revert:
    >
    > Author: Thomas Gleixner <tglx@linutronix.de>
    > Date:   Sat Jul 16 18:38:22 2011 +0200
    >
    >    seqlock-remove-unused-functions.patch
    >
    >    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    >
    > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    > ---
    >  include/linux/seqlock.h |   21 +++++++++++++++++++++
    >  1 files changed, 21 insertions(+), 0 deletions(-)
    >
    > diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
    > index b990f6e..c6db9fb 100644
    > --- a/include/linux/seqlock.h
    > +++ b/include/linux/seqlock.h
    > @@ -69,6 +69,17 @@ static inline void write_sequnlock(seqlock_t *sl)
    >        spin_unlock(&sl->lock);
    >  }
    >
    > +static inline int write_tryseqlock(seqlock_t *sl)
    > +{
    > +       int ret = spin_trylock(&sl->lock);
    > +
    > +       if (ret) {
    > +               ++sl->sequence;
    > +               smp_wmb();
    > +       }
    > +       return ret;
    > +}
    > +
    >  /* Start of read calculation -- fetch last complete writer token */
    >  static __always_inline unsigned read_seqbegin(const seqlock_t *sl)
    >  {
    > @@ -237,4 +248,14 @@ static inline void write_seqcount_barrier(seqcount_t *s)
    >  #define write_sequnlock_bh(lock)                                       \
    >        do { write_sequnlock(lock); local_bh_enable(); } while(0)
    >
    > +#define read_seqbegin_irqsave(lock, flags)                             \
    > +       ({ local_irq_save(flags);   read_seqbegin(lock); })
    > +
    > +#define read_seqretry_irqrestore(lock, iv, flags)                      \
    > +       ({                                                              \
    > +               int ret = read_seqretry(lock, iv);                      \
    > +               local_irq_restore(flags);                               \
    > +               ret;                                                    \
    > +       })
    > +
    >  #endif /* __LINUX_SEQLOCK_H */
    > --

    Does this really need to be reverted? I don't believe the other
    reverts make use of these functions either. Looking upstream ,they are
    also not used here, so the original patch should be pushed upstream if
    anything.

    Thanks

    John
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-06 23:41    [W:0.026 / U:0.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site