lkml.org 
[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/5] mips: Use common fork_idle_from_wq in smpboot
    Date
    Cleanup. Instead of reimplementing fork_idle on wq and idle task caching,
    use fork_idle_from_wq().

    Signed-off-by: Venkatesh Pallipadi <venki@google.com>
    ---
    arch/mips/kernel/smp.c | 47 +++--------------------------------------------
    1 files changed, 3 insertions(+), 44 deletions(-)

    diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
    index 32c1e95..37a4133 100644
    --- a/arch/mips/kernel/smp.c
    +++ b/arch/mips/kernel/smp.c
    @@ -191,54 +191,13 @@ void __devinit smp_prepare_boot_cpu(void)
    * and keep control until "cpu_online(cpu)" is set. Note: cpu is
    * physical, not logical.
    */
    -static struct task_struct *cpu_idle_thread[NR_CPUS];
    -
    -struct create_idle {
    - struct work_struct work;
    - struct task_struct *idle;
    - struct completion done;
    - int cpu;
    -};
    -
    -static void __cpuinit do_fork_idle(struct work_struct *work)
    -{
    - struct create_idle *c_idle =
    - container_of(work, struct create_idle, work);
    -
    - c_idle->idle = fork_idle(c_idle->cpu);
    - complete(&c_idle->done);
    -}
    -
    int __cpuinit __cpu_up(unsigned int cpu)
    {
    struct task_struct *idle;

    - /*
    - * Processor goes to start_secondary(), sets online flag
    - * The following code is purely to make sure
    - * Linux can schedule processes on this slave.
    - */
    - if (!cpu_idle_thread[cpu]) {
    - /*
    - * Schedule work item to avoid forking user task
    - * Ported from arch/x86/kernel/smpboot.c
    - */
    - struct create_idle c_idle = {
    - .cpu = cpu,
    - .done = COMPLETION_INITIALIZER_ONSTACK(c_idle.done),
    - };
    -
    - INIT_WORK_ONSTACK(&c_idle.work, do_fork_idle);
    - schedule_work(&c_idle.work);
    - wait_for_completion(&c_idle.done);
    - idle = cpu_idle_thread[cpu] = c_idle.idle;
    -
    - if (IS_ERR(idle))
    - panic(KERN_ERR "Fork failed for CPU %d", cpu);
    - } else {
    - idle = cpu_idle_thread[cpu];
    - init_idle(idle, cpu);
    - }
    + idle = fork_idle_from_wq(cpu);
    + if (IS_ERR(idle))
    + panic(KERN_ERR "Fork failed for CPU %d", cpu);

    mp_ops->boot_secondary(cpu, idle);

    --
    1.7.7.3


    \
     
     \ /
      Last update: 2012-03-06 22:45    [W:0.024 / U:86.664 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site