Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCHv2 3/3] misc: rename bmp085 to bmp18x | Date | Tue, 6 Mar 2012 21:14:30 +0000 |
| |
On Tuesday 06 March 2012, Eric Andersson wrote: > The bmp085 chip has been deprecated by the newer bmp18x chip family from > Bosch Sensortec. > > Reviewed-by: Stefan Nilsson <stefan.nilsson@unixphere.com> > Signed-off-by: Eric Andersson <eric.andersson@unixphere.com> > --- > drivers/misc/Kconfig | 18 +- > drivers/misc/Makefile | 6 +- > drivers/misc/bmp085.c | 514 -------------------------------------------- > drivers/misc/bmp18x-i2c.c | 132 +++++++++++ > drivers/misc/bmp18x-spi.c | 140 ++++++++++++ > drivers/misc/bmp18x.c | 512 +++++++++++++++++++++++++++++++++++++++++++ > include/linux/i2c/bmp085.h | 63 ------ > include/linux/i2c/bmp18x.h | 63 ++++++ > 8 files changed, 859 insertions(+), 589 deletions(-)
Please use 'git format-patch -M' when sending a rename patch, to make it obvious that there are no code changes in the rename. It's a bit suspicous that the files are different size and that you remove one .c file but add three other ones.
You should also try give a better explanation why the rename is actually a good idea. Simply listing the old model as deprecated does not sound like a strong enough reason, given that some people might rely on the existing name in user space interfaces.
Arnd
| |