Messages in this thread | | | Subject | Re: [RFC PATCH] checkpatch: Warn on use of yield() | From | Joe Perches <> | Date | Tue, 06 Mar 2012 09:41:06 -0800 |
| |
On Tue, 2012-03-06 at 13:45 +0100, Peter Zijlstra wrote: > The case at hand was a life-lock due to expecting that yield() would run > another process which it needed in order to complete. Yield() does not > provide that guarantee.
OK.
Perhaps the kernel-doc comments in sched/core.c should/could be expanded/updated.
/** * sys_sched_yield - yield the current processor to other threads. * * This function yields the current CPU to other tasks. If there are no * other threads running on this CPU then this function will return. */
[]
/** * yield - yield the current processor to other threads. * * This is a shortcut for kernel-space yielding - it marks the * thread runnable and calls sys_sched_yield(). */ void __sched yield(void) { set_current_state(TASK_RUNNING); sys_sched_yield(); } EXPORT_SYMBOL(yield);
| |