[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: lib/string.h build failure in linux-next
On Tue, 2012-03-06 at 16:02 +0000, Arnd Bergmann wrote:
> On Tuesday 06 March 2012, Mark Salter wrote:
> > I'm seeing a build failure in lib/string.h in linux-next:
> >
> > /es/linux/linux-next/lib/string.c: In function 'strlcat':
> > /es/linux/linux-next/lib/string.c:225:2: error: implicit declaration of function 'printk'
> > /es/linux/linux-next/lib/string.c:225:2: error: implicit declaration of function 'panic'
> >
> > Commit e2950c2b6ecb928bfd3a13dd237df1f29f712704 removed an include of
> > linux/module.h which triggered the problem for arch/c6x and probably
> > other architectures using the asm-generic BUG macro.
> >
> > I think this needs fixing in asm-generic/bug.h which should include
> > linux/kernel.h for panic and linux/printk.h for printk.
> I think you cannot do that as long as linux/kernel.h includes asm/bug.h,
> or you will get a lot of other build failures.

It didn't for my build, but to tell the truth, I really wasn't too keen
on adding an include of kernel.h to asm/bug.h since kernel.h pulls in so
much other stuff.

> The safer option is probably to add the two missing headers separately
> to string.c.

Okay, I can put together a patch that does that.


 \ /
  Last update: 2012-03-06 17:19    [W:0.047 / U:4.164 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site