[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124
On Tue, Mar 06, 2012 at 07:49:16PM +0900, Tomoya MORINAGA wrote:
> On Tue, Mar 06, 2012 19:00 Mark Brown <>:

> > This is not what the above prototype says, the above prototype has only
> > one register in it. You need to make this *much* clearer for the
> > registers it's affecting.

> Sorry, I couldn't understand your saying / concern.
> Do you mean I shouldn't use ml26124_update_bits() but snd_soc_update_bits() ?

Ideally you should be using the framework features. If there is some
reason why you can't you need to make it much clearer what the reason
is so people reading the code can understand.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2012-03-06 13:15    [W:0.134 / U:1.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site