[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124
    On Tue, Mar 06, 2012 19:00 Mark Brown <>:
    > This is not the case. As I have *REPEATEDLY* told you you should be
    > sumbitting code against current development versions of the subsystem.
    You are right. v3.3-rc6 uses it. sorry for inconvenience.

    >> >> +static int ml26124_update_bits(struct snd_soc_codec *codec, unsigned short reg,
    >> >> + unsigned int mask, unsigned int value)
    >> > Why are you open coding this in your driver? There is no point in
    >> > replicating subsystem functionality.
    >> For ML26124 spec, it's necessary.
    >> Because the codec's register read-address and write-address is not the same.
    >> E.G.
    >> Sampling Rate Register
    >> R: offset=0
    >> W: offset=1
    > This is not what the above prototype says, the above prototype has only
    > one register in it. You need to make this *much* clearer for the
    > registers it's affecting.
    Sorry, I couldn't understand your saying / concern.
    Do you mean I shouldn't use ml26124_update_bits() but snd_soc_update_bits() ?

    ROHM Co., Ltd.

     \ /
      Last update: 2012-03-06 11:51    [W:0.028 / U:0.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site