lkml.org 
[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124
From
On Tue, Mar 06, 2012 19:00 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> This is not the case. As I have *REPEATEDLY* told you you should be
> sumbitting code against current development versions of the subsystem.
You are right. v3.3-rc6 uses it. sorry for inconvenience.

>> >> +static int ml26124_update_bits(struct snd_soc_codec *codec, unsigned short reg,
>> >> + unsigned int mask, unsigned int value)
>> > Why are you open coding this in your driver? There is no point in
>> > replicating subsystem functionality.
>>
>> For ML26124 spec, it's necessary.
>> Because the codec's register read-address and write-address is not the same.
>> E.G.
>> Sampling Rate Register
>> R: offset=0
>> W: offset=1
>
> This is not what the above prototype says, the above prototype has only
> one register in it. You need to make this *much* clearer for the
> registers it's affecting.
Sorry, I couldn't understand your saying / concern.
Do you mean I shouldn't use ml26124_update_bits() but snd_soc_update_bits() ?

thanks,
--
ROHM Co., Ltd.
tomoya


\
 
 \ /
  Last update: 2012-03-06 11:51    [from the cache]
©2003-2011 Jasper Spaans