Messages in this thread | | | Date | Tue, 6 Mar 2012 14:49:24 +0900 | Subject | Re: [PATCH v5] sound/soc/lapis: add machine driver for ML7213 Carrier Board | From | Tomoya MORINAGA <> |
| |
2012年3月2日22:05 Mark Brown <broonie@opensource.wolfsonmicro.com>: > On Thu, Feb 23, 2012 at 02:46:51PM +0900, Tomoya MORINAGA wrote: > >> This option enables support for the AC Link Controllers in ML7213 IOH SoC. >> +config SND_SOC_ML7213_MACHINE >> + tristate "ML7213 IOH ASoC machine driver" >> + select SND_SOC_ML7213_PLATFORM >> + help >> + This is ASoC machine driver for ML7213 IOH > > This needs to depend on the CODEC as well, how have you tested? OK, will add this.
When I test this, I selected "Build all ASoC ...." of Kconfig
> You're also missing a blank line between this and the previous stanza. Sorry, I can't understand your saying.
> >> +static struct platform_device *ioh_snd_device; >> + >> + >> +static int __init ioh_i2s_init(void) >> +{ >> + int ret; >> + ioh_snd_device = platform_device_alloc("soc-audio", -1); >> + if (!ioh_snd_device) >> + return -ENOMEM; > > Use snd_soc_register_card() and a real device. OK. As a matter of interest, why do you recommend me to use snd_soc_register_card() ? At present, many ASoC drivers use platform_device_alloc.
thanks, -- ROHM Co., Ltd. tomoya
| |