lkml.org 
[lkml]   [2012]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv5] EDAC core changes in order to properly report errors from all types of memory controllers
    On Mon, Mar 05, 2012 at 07:00:04PM -0300, Mauro Carvalho Chehab wrote:
    > With those changes, there's just one tracepont defined there, on this patchset:
    > http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-edac.git;a=commit;h=fdfa64045e43c942e1250708365d9240cd0da9c3

    Ok, here's my take from simply skimming over the patchset for 5 mins:

    * first of all, a lot of the patches are done sloppily and have no commit
    messages whatsoever. This is a no-no and the first thing you need to fix.

    * http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-edac.git;a=commitdiff;h=ad015450e549b29a74283733048254d3c647a33at is humongous, has no commit message and contains a lot of changes which probably deserve a patch of their own. Mauro, you're not doing this since yesterday, you should know better!

    * http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-edac.git;a=commitdiff;h=ccca89bce4c0515aabd67440ba01ede97d2b4dcc removes crap introduced by earlier patches in the series, so also a no-no and needs to be fixed.

    * WTF does the commit message of http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-edac.git;a=commitdiff;h=c911a426ef72c817222e7c2ab302a81b69ccbd07 mean? Looks like it redacts a huge function you've introduced in an earlier patch... Hell, no!

    ...

    * And, last but not least, your patches touch amd64_edac* extensively,
    and, I need to properly review those changes before they get committed.

    So, my absolutely sincere suggestion to you is to split this huge
    patchset into smaller patchsets containing 5-10 patches, making it much
    easier to review, go over <Documentation/SubmittingPatches> and refresh
    your knowledge on how a proper patch should look like and what it should
    contain, test your stuff properly on the machines it addresses and
    _only_ _then_ send them to the relevant parties for proper review - not
    earlier.

    HTH.

    --
    Regards/Gruss,
    Boris.

    Advanced Micro Devices GmbH
    Einsteinring 24, 85609 Dornach
    GM: Alberto Bozzo
    Reg: Dornach, Landkreis Muenchen
    HRB Nr. 43632 WEEE Registernr: 129 19551


    \
     
     \ /
      Last update: 2012-03-06 00:25    [W:0.023 / U:0.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site