Messages in this thread | | | Date | Mon, 5 Mar 2012 19:57:59 +0100 | Subject | Re: [PATCH 2/3] dma-buf: add support for kernel cpu access | From | Daniel Vetter <> |
| |
On Fri, Mar 2, 2012 at 23:24, Rob Clark <robdclark@gmail.com> wrote: > Perhaps we should check somewhere for required dmabuf ops fxns (like > kmap_atomic here), rather than just calling unconditionally what might > be a null ptr. At least put it in the WARN_ON(), but it might be > nicer to catch a missing required fxns at export time, rather than > waiting for an importer to try and call it. Less likely that way, for > newly added required functions go unnoticed. > > (same comment applies below for the non-atomic variant.. and possibly > some other existing dmabuf ops)
Agreed, I'll rework the patch to do that when rebasing onto Sumit's latest tree. -Daniel -- Daniel Vetter daniel.vetter@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |